[Frontend] Enter the homepage immediately after signing up #576
+290
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiawpohr
reviewed
Nov 20, 2024
| } else { | ||
| callback() | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggest to refactor this codes in the more modern style such as async/await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
刪除 ProtectedRoute 並且在不同動作新增 Checker
Linked Issue
close #561
Details
目前用戶在還沒有執行跟身分相關的動作時，可以做所有頁面的檢視，但在執行相關，例如發文留言，的時候會跳出警示，並將用戶導到登入頁。